Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigate memory leak #5152

Merged
merged 1 commit into from
Nov 21, 2024
Merged

mitigate memory leak #5152

merged 1 commit into from
Nov 21, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 20, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

I still haven't tracked down the source of the memory leak, but the repro is something like:

  • upload a ~10MB text file to the workspace
  • ask openhands to run cat bigfile.txt
  • repeatedly refresh the page

You'll see mem usage jump by ~12MB on each refresh.

This seems to cut down on most of the leakage, but there's probably a separate leak somewhere


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:9cab1e9-nikolaik   --name openhands-app-9cab1e9   docker.all-hands.dev/all-hands-ai/openhands:9cab1e9

@rbren rbren marked this pull request as ready for review November 20, 2024 21:06
Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little curious, I don't see problems though, let's try it.

@neubig neubig merged commit 27f136b into main Nov 21, 2024
13 checks passed
@neubig neubig deleted the rb/mem-leak branch November 21, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants